Skip to content

Right-align modal footer buttons and stack Settings extra row#521

Merged
NikTilton merged 1 commit into
mainfrom
jschick/modal-footer-fix
May 13, 2026
Merged

Right-align modal footer buttons and stack Settings extra row#521
NikTilton merged 1 commit into
mainfrom
jschick/modal-footer-fix

Conversation

@jschick04
Copy link
Copy Markdown
Collaborator

Fixes modal footer alignment across all dialogs.

Bugs

  • Settings: Save/Exit buttons rendered inline with the "Pre-release Builds" toggle on the same row.
  • Release Notes: Close button left-aligned instead of right.
  • General: several modals had buttons at the wrong edge of the footer.

Root cause

.footer-group { justify-content: space-between; } left single-button footers pinned to the left and split paired buttons. With ExtraFooterContent it forced the toggle and the action buttons to share one row.

Fix

  • .footer-group now uses flex-wrap: wrap + justify-content: flex-end so buttons right-align by default.
  • New opt-in StackFooterExtra parameter on ModalChrome adds footer-extra-stacked to the extra slot so it consumes a full row above the buttons. Settings opts in; DebugLog stays inline (its custom grid keeps the Exit button next to Refresh/Clear).
  • Added .footer-group > .button-group:not(:last-child) { margin-right: auto; } to preserve the Import/Export-left + Close-right split for FooterPreset.ImportExportClose (FilterCacheModal, FilterGroupModal).
  • Removed the unused .footer-group.align-right selector.

Verified

  • Build clean.
  • EventLogExpert.Components.Tests and EventLogExpert.UI.Tests pass.
  • Visually confirmed in the running MAUI app: Settings, Release Notes, Saved Filters, Filter Groups, Debug Log, and alert/prompt modals all render footers as expected.

@jschick04 jschick04 requested a review from a team as a code owner May 13, 2026 02:37
Copilot AI review requested due to automatic review settings May 13, 2026 02:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes modal footer layout so action buttons right-align by default and optional “extra” footer content can be stacked onto its own row (fixing Settings’ footer crowding and Release Notes’ left-aligned Close button).

Changes:

  • Updated .footer-group to wrap and right-align footer actions by default; added rules to optionally stack .footer-extra and preserve the Import/Export-left + Close-right split.
  • Added StackFooterExtra parameter to ModalChrome to opt ExtraFooterContent into a full-width stacked row.
  • Enabled stacked extra footer content in SettingsModal to keep the toggle row separate from Save/Exit actions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/EventLogExpert/wwwroot/css/app.css Reworks modal footer flex behavior (wrap + right alignment), adds stacked-extra and Import/Export split styling, removes unused selector.
src/EventLogExpert.Components/Modals/SettingsModal.razor Opts Settings into stacked extra footer row to prevent toggle and buttons sharing the same row.
src/EventLogExpert.Components/Base/ModalChrome.razor.cs Introduces StackFooterExtra parameter (documented) to control footer-extra stacking behavior.
src/EventLogExpert.Components/Base/ModalChrome.razor Applies stacked class to the extra footer slot when StackFooterExtra is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NikTilton NikTilton merged commit 2a67d31 into main May 13, 2026
10 checks passed
@NikTilton NikTilton deleted the jschick/modal-footer-fix branch May 13, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants