Right-align modal footer buttons and stack Settings extra row#521
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes modal footer layout so action buttons right-align by default and optional “extra” footer content can be stacked onto its own row (fixing Settings’ footer crowding and Release Notes’ left-aligned Close button).
Changes:
- Updated
.footer-groupto wrap and right-align footer actions by default; added rules to optionally stack.footer-extraand preserve the Import/Export-left + Close-right split. - Added
StackFooterExtraparameter toModalChrometo opt ExtraFooterContent into a full-width stacked row. - Enabled stacked extra footer content in
SettingsModalto keep the toggle row separate from Save/Exit actions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EventLogExpert/wwwroot/css/app.css | Reworks modal footer flex behavior (wrap + right alignment), adds stacked-extra and Import/Export split styling, removes unused selector. |
| src/EventLogExpert.Components/Modals/SettingsModal.razor | Opts Settings into stacked extra footer row to prevent toggle and buttons sharing the same row. |
| src/EventLogExpert.Components/Base/ModalChrome.razor.cs | Introduces StackFooterExtra parameter (documented) to control footer-extra stacking behavior. |
| src/EventLogExpert.Components/Base/ModalChrome.razor | Applies stacked class to the extra footer slot when StackFooterExtra is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NikTilton
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes modal footer alignment across all dialogs.
Bugs
Root cause
.footer-group { justify-content: space-between; }left single-button footers pinned to the left and split paired buttons. WithExtraFooterContentit forced the toggle and the action buttons to share one row.Fix
.footer-groupnow usesflex-wrap: wrap+justify-content: flex-endso buttons right-align by default.StackFooterExtraparameter onModalChromeaddsfooter-extra-stackedto the extra slot so it consumes a full row above the buttons. Settings opts in; DebugLog stays inline (its custom grid keeps the Exit button next to Refresh/Clear)..footer-group > .button-group:not(:last-child) { margin-right: auto; }to preserve the Import/Export-left + Close-right split forFooterPreset.ImportExportClose(FilterCacheModal, FilterGroupModal)..footer-group.align-rightselector.Verified
EventLogExpert.Components.TestsandEventLogExpert.UI.Testspass.