Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.Threading.Tasks;

/// <summary>
/// A task to determine customer phone numbers with alpha characters.
/// A task to determine customer phone or fax numbers with alpha characters.
/// </summary>
public class GpCustomerPhoneNumberAlphaTask : IDiagnosticTask
{
Expand Down Expand Up @@ -50,7 +50,7 @@ public async Task StartAsync(CancellationToken cancellationToken)
FROM
[RM00101]
WHERE
[PHONE1] LIKE '%[^0-9 ]%'
([PHONE1] LIKE '%[^0-9 ]%' OR [FAX] LIKE '%[^0-9 ]%')
AND [INACTIVE] = 0 --Remove to include all Customers";

using (var reader = await this.database.ExecuteSqlAsync(sql, cancellationToken))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.Threading.Tasks;

/// <summary>
/// A task to determine vendor phone numbers with alpha characters.
/// A task to determine vendor phone or fax numbers with alpha characters.
/// </summary>
public class GpVendorPhoneNumberAlphaTask : IDiagnosticTask
{
Expand Down Expand Up @@ -50,7 +50,7 @@ public async Task StartAsync(CancellationToken cancellationToken)
FROM
[PM00200]
WHERE
[PHNUMBR1] LIKE '%[^0-9 ]%'
([PHNUMBR1] LIKE '%[^0-9 ]%' OR [FAXNUMBR] LIKE '%[^0-9 ]%')
AND VENDSTTS = 1 --Remove to include all Vendors";

using (var reader = await this.database.ExecuteSqlAsync(sql, cancellationToken))
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions samples/DynamicsGPDiagnosticTool/GP_Diagnostic/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@
<comment>{0} = Number of customers</comment>
</data>
<data name="GpCustomerPhoneNumberAlphaTaskDescription" xml:space="preserve">
<value>Active customer phone numbers with alpha characters</value>
<value>Active customers with alpha characters in phone/fax numbers</value>
</data>
<data name="GpCustomerPhoneNumberAlphaTaskSummary" xml:space="preserve">
<value>{0} active customer(s) with phone numbers that contain alpha characters. Business Central does not allow alpha characters in phone numbers. The Customers will still be migrated, but the phone numbers will be skipped.</value>
<value>{0} active customer(s) with alpha characters in phone/fax numbers. Business Central does not allow alpha characters in phone or fax numbers. The Customers will still be migrated, but the phone/fax numbers will be skipped.</value>
<comment>{0} = Number of customers</comment>
</data>
<data name="GpDirectTransactionsPostingToRetainedEarningsAccountTaskDescription" xml:space="preserve">
Expand Down Expand Up @@ -363,10 +363,10 @@
<comment>{0} = Number of vendors</comment>
</data>
<data name="GpVendorPhoneNumberAlphaTaskDescription" xml:space="preserve">
<value>Active vendor phone numbers with alpha characters</value>
<value>Active vendors with alpha characters in phone/fax numbers</value>
</data>
<data name="GpVendorPhoneNumberAlphaTaskSummary" xml:space="preserve">
<value>{0} active vendor(s) detected with phone numbers that contain alpha characters. Business Central does not allow alpha characters in phone numbers. The vendors will still be migrated, but the phone numbers will be skipped.</value>
<value>{0} active vendor(s) detected with alpha characters in phone/fax numbers. Business Central does not allow alpha characters in phone or fax numbers. The vendors will still be migrated, but the phone/fax numbers will be skipped.</value>
<comment>{0} = Number of vendors</comment>
</data>
<data name="GpVerifyPostingTypesTaskDescription" xml:space="preserve">
Expand Down