Skip to content

[Quality Mgmt.] Bug 624560: Fixing Translated Label Inconsistencies#7036

Open
attilatoury wants to merge 3 commits intomainfrom
bugs/624560-qm-label-translation-inconsistency
Open

[Quality Mgmt.] Bug 624560: Fixing Translated Label Inconsistencies#7036
attilatoury wants to merge 3 commits intomainfrom
bugs/624560-qm-label-translation-inconsistency

Conversation

@attilatoury
Copy link
Contributor

@attilatoury attilatoury commented Mar 9, 2026

Fixes AB#624560

Fix translation inconsistency for inspection result codes (FAIL, INPROGRESS, PASS)

The demo data app redefined the FAIL, INPROGRESS, and PASS code labels without Locked = true, while the main app's QltyAutoConfigure had them locked. In translated environments, the demo data inserted records with translated codes (e.g., IN BEARBEITUNG) that failed validation against the main app's locked values.

Fix: Removed the duplicated labels from CreateQualityInspResult and replaced them with calls to new public getter procedures on QltyAutoConfigure (GetDefaultFailResult, GetDefaultInProgressResult, and corresponding description getters), ensuring the demo data always uses the exact same locked values as the main app.

Also fixed EcoliPresentDescLbl which incorrectly used the raw code token 'ECOLIPRESENT' instead of a human-readable description.

ADDITIONALLY:
Locking all the labels used as primary key as the easiest acceptable fix for the following issue:

Root cause: The Qlty. Test table's Code field has an OnValidate trigger that strips special characters (e.g. spaces). When a Tok label like 'ECOLIPRESENT' gets translated to 'ECOLI PRESENT', two things happen:
InsertQualityTest validates the Code → OnValidate strips the space → record is stored as 'ECOLIPRESENT'
InsertQualityInspectionTemplateLine validates "Test Code" with the raw translated value 'ECOLI PRESENT' → tries QltyTest.Get('ECOLI PRESENT') → record not found
Fix: Add Locked = true to all Tok labels used as Code/identifier values in CreateQualityTest, CreateQualityLookupValue, and CreateQMInspTemplateHdr, preventing translation of these primary key values.

…o data apps + improve one description label in demo data
@attilatoury attilatoury requested a review from a team as a code owner March 9, 2026 15:44
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Mar 9, 2026
@github-actions github-actions bot added this to the Version 29.0 milestone Mar 9, 2026
PredragMaricic
PredragMaricic previously approved these changes Mar 9, 2026
…er that strips special characters (e.g. spaces). When a Tok label like 'ECOLIPRESENT' gets translated to 'ECOLI PRESENT', two things happen:

InsertQualityTest validates the Code → OnValidate strips the space → record is stored as 'ECOLIPRESENT'
InsertQualityInspectionTemplateLine validates "Test Code" with the raw translated value 'ECOLI PRESENT' → tries QltyTest.Get('ECOLI PRESENT') → record not found
Fix: Add Locked = true to all Tok labels used as Code/identifier values in CreateQualityTest, CreateQualityLookupValue, and CreateQMInspTemplateHdr, preventing translation of these primary key values.
…624560-qm-label-translation-inconsistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants