Skip to content

Github Actions pinned with full SHA#4886

Merged
tamirkamara merged 2 commits intomainfrom
tamirkamara/pin-actions-sha
Mar 23, 2026
Merged

Github Actions pinned with full SHA#4886
tamirkamara merged 2 commits intomainfrom
tamirkamara/pin-actions-sha

Conversation

@tamirkamara
Copy link
Copy Markdown
Collaborator

What is being addressed

Github actions steps are currently using version tags which is less secured.

How is this addressed

  • Convert to use full SHA
  • Update various actions to their latest release

@tamirkamara tamirkamara requested a review from a team as a code owner March 23, 2026 10:46
Copilot AI review requested due to automatic review settings March 23, 2026 10:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ffb9181.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the repository’s CI/CD supply chain by pinning GitHub Actions uses: references to immutable commit SHAs and updating several actions to newer releases across workflows (and one composite action).

Changes:

  • Pin third-party and GitHub-maintained Actions in workflows to full commit SHAs (instead of version tags).
  • Update multiple Actions to newer major/minor releases while pinning.
  • Add an Unreleased changelog entry describing the change.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CHANGELOG.md Adds an Unreleased entry describing the workflow action pinning/update.
.github/workflows/test_results.yml Pins publish/check Actions to full SHAs.
.github/workflows/pr_comment_bot.yml Pins checkout/github-script/azure-login/checks-action to full SHAs.
.github/workflows/lets_encrypt.yml Pins checkout/setup-terraform/azure-login to full SHAs.
.github/workflows/flag_external_pr.yml Pins checkout/github-script to full SHAs.
.github/workflows/deploy_tre_reusable.yml Pins multiple Actions (checkout/buildx/login/artifact/etc.) to full SHAs.
.github/workflows/codeql-analysis.yml Pins checkout/codeql/init+analyze/setup-java to full SHAs.
.github/workflows/cli-package.yml Pins checkout/upload-artifact to full SHAs.
.github/workflows/clean_validation_envs.yml Pins checkout/azure-login to full SHAs.
.github/workflows/build_validation_develop.yml Pins checkout/paths-filter/setup-terraform/super-linter to full SHAs.
.github/workflows/build_docs.yml Pins checkout/setup-python to full SHAs.
.github/workflows/build_docker_images.yml Pins multiple Actions (artifact/checkout/filter/setup/buildx/build-push/etc.) to full SHAs.
.github/actions/devcontainer_run_command/action.yml Pins azure/login used by the composite action to a full SHA.

Copy link
Copy Markdown
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine if it works :)

@tamirkamara
Copy link
Copy Markdown
Collaborator Author

/test-force-approve
E2E run from the main branch anyway

@github-actions
Copy link
Copy Markdown

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ffb9181)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) March 23, 2026 12:51
Copy link
Copy Markdown
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara tamirkamara merged commit af4bd5f into main Mar 23, 2026
14 checks passed
@tamirkamara tamirkamara deleted the tamirkamara/pin-actions-sha branch March 23, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants