Skip to content

[Bug]: Two sessions can process the same Audit File Export Line simul… #29821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlkov wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

[Bug]: Two sessions can process the same Audit File Export Line simul… #29821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Apps/W1/AuditFileExport/app/src/ExportEngine/AuditFileExportMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,16 @@ codeunit 5261 "Audit File Export Mgt."
OnBeforeScheduleTask(DoNotScheduleTask, TaskID);
if DoNotScheduleTask then
AuditFileExportLine."Task ID" := TaskID
else
else begin
if not IsNullGuid(AuditFileExportLine."Task ID") then
if TaskScheduler.TaskExists(AuditFileExportLine."Task ID") then
TaskScheduler.CancelTask(AuditFileExportLine."Task ID");

AuditFileExportLine."Task ID" :=
TaskScheduler.CreateTask(
Codeunit::"Audit Line Export Runner", Codeunit::"Audit File Export Error Handl.", true, CompanyName(),
NotBefore, AuditFileExportLine.RecordId());
end;
AuditFileExportLine.Modify(true);
Commit();
NoOfJobs += 1;
Expand Down
5 changes: 5 additions & 0 deletions Apps/W1/AuditFileExport/app/src/ExportEngine/AuditLineExportRunner.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ codeunit 5265 "Audit Line Export Runner"
FileContentInStream: InStream;
begin
Rec.LockTable();
Rec.Find();
if (Rec."Session ID" <> 0) and (Rec."Session ID" <> SessionId()) then
if Rec."Server Instance ID" = ServiceInstanceId() then
if Session.IsSessionActive(Rec."Session ID") then
exit;
Rec.Validate("Server Instance ID", ServiceInstanceId());
Rec.Validate("Session ID", SessionId());
Rec.Validate("Created Date/Time", 0DT);
Expand Down
Loading