Add keyboard shortcuts to adjust timer by minutes#148
Open
owenmead wants to merge 4 commits intomichaelvillar:masterfrom
Open
Add keyboard shortcuts to adjust timer by minutes#148owenmead wants to merge 4 commits intomichaelvillar:masterfrom
owenmead wants to merge 4 commits intomichaelvillar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds keyboard shortcuts to increment or decrement the timer while it is
running or paused, without needing to re-enter a time manually.
+or↑-or↓shift++orshift+↑shift+-orshift+↓Timer is clamped at 0 — subtracting below zero has no effect.
Changes
MVClockView+Behavior.swift— AddedadjustMinutes(by:)helper andwired up
+/-/↑/↓keys (with optionalshiftmodifier for ±10minutes) in
keyUp(with:).README.md— Reformatted keyboard shortcut list as a table anddocumented the new shortcuts.
TimerKeyboardInputTests.swift— Added UI tests covering all new keycombinations, the zero-clamp behaviour, and adjustment while the timer is
running.