Update MQTT connection parameters to use environment variables#91
Open
mietzen wants to merge 3 commits intomiaucl:masterfrom
Open
Update MQTT connection parameters to use environment variables#91mietzen wants to merge 3 commits intomiaucl:masterfrom
mietzen wants to merge 3 commits intomiaucl:masterfrom
Conversation
github-actions
bot
added
the
📖 documentation
Corrected spelling of 'Environment' in README.
Owner
|
Hey, thanks for the PR. In this case, I can understand the problem with the passwords. Why not allow to set all the parameters with via a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to use connection parameters from environment variables.
Currently
/proc/pid/cmdlinewill leak our user credentials. This PR enables us to use a environment file when starting the process via e.g. a systemd service:EnvironmentFile=/opt/linux2mqtt/.envThe changes are non breaking, if no environment variables are set
linux2mqttwill behave the same as before with or without--username/--password.