Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 19 19
Lines 3360 3360
Branches 494 494
=======================================
Hits 3220 3220
Misses 81 81
Partials 59 59 Continue to review full report at Codecov.
|
shuebner
force-pushed
the
feature/277_add_source_generator
branch
from
076c4ed to
3121216
Compare
shuebner
force-pushed
the
feature/277_add_source_generator
branch
from
1c0219a to
c15b24d
Compare
use ItemMetadata instead of global configuration
also add option for prefix
work-around for assembly mismatch and missing method exception when building in environments that have System.Collections.Immutable 5.0.0 loaded at source generator runtime
shuebner
force-pushed
the
feature/277_add_source_generator
branch
from
cfbe9c3 to
c4f8e4d
Compare
|
Is this still a viable PR? |
Author
|
@DaveVdE it is more a PoC than a viable MVP, so I would say no. Feel free to take over this PR branch as a basis and add the missing MVP features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the delay. I had less time than expected. Here is at least a working POC (nuget package untested) with a global namespace setting.
Next, I will add test cases for multiple schema files and then also add all applicable command line options to the source generator.
We will see how much code duplication will temporarily emerge from this and then may need to discuss refactoring e. g. configuration building or output writing to eliminate it again.