Skip to content

Fix out-of-bounds read in PATH payload parsing #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weebl2000 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix out-of-bounds read in PATH payload parsing #1654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c4e0b
fix bounds check on PAYLOAD_TYPE_PATH decrypted data
weebl2000 Feb 11, 2026
244db70
add debug log for malformed PATH payload
weebl2000 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ DispatcherAction Mesh::onRecvPacket(Packet* pkt) {
if (pkt->getPayloadType() == PAYLOAD_TYPE_PATH) {
int k = 0;
uint8_t path_len = data[k++];
if (k + path_len + 1 > len) { // bounds check: need path_len bytes + extra_type byte
MESH_DEBUG_PRINTLN("%s Mesh::onRecvPacket(): bad PATH payload format, path_len=%d len=%d", getLogDateTime(), (int)path_len, (int)len);
break;
}
uint8_t* path = &data[k]; k += path_len;
uint8_t extra_type = data[k++] & 0x0F; // upper 4 bits reserved for future use
uint8_t* extra = &data[k];
Expand Down