-
Notifications
You must be signed in to change notification settings - Fork 103
Fixed sphinx dependency issue for documentation build #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixed sphinx dependency issue for documentation build #1197
Conversation
📝 WalkthroughWalkthroughMoved Sphinx-related dependency declarations from the GitHub Actions workflow to the repository Pipfile and reformatted exception message strings in a client HTTP module; documentation build steps in the workflow remain unchanged aside from the removed explicit installs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Strift Can you please trigger workflow before merging this PR? |
|
@Strift I tried it on my fork and it worked for me https://github.com/jawad-khan/meilisearch-python/actions/runs/21169618669 |
curquiza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thank you @jawad-khan!!
Pull Request
Related issue
Fixes #1193
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.