feat(SF2.0): Display Ferry predictions similar to CR#3081
Open
feat(SF2.0): Display Ferry predictions similar to CR#3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Render ferry predictions the same way as CR
Implementation
Changes the function guards for arrival status to include ferry instead of just commuter rail.
Added ferry to all the tests that were schedule related that included a commuter rail route, which includes some things that aren't affected by this code change directly, but do seem like behavior we expect. The tests passed even after repeating 300 times, so it's probably fine?
Screenshots
Currently no live data, but here's what it looks like without current arrivals.
Before
After
How to test
You can see this on any ferry SF2.0 (Hingam for convenience). We currently don't have live data though.