chore(ScheduleFinderLive): don't show errors#3080
Merged
thecristen merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
lvachon1
approved these changes
Apr 3, 2026
Contributor
lvachon1
left a comment
lvachon1
left a comment
There was a problem hiding this comment.
Looks pretty straightforward to me. I don't think we use rider screenshots of error messages in debugging much (at all?), so as long as splunk or something is capturing these rare error cases we should be good.
If we do want to keep that option, putting the error details in a collapsable section, a hidden div or even the console log might prove useful in the future.
Collaborator
Author
|
@lvachon1 Great points, I forgot to mention that these errors DO get logged in the backend every time so yeah we're good! 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Just cleaning up some things and started thinking about error handling. I thought the error display we currently support is somewhat verbose and unhelpful.
Implementation
Removed the title attribute.
Screenshots
How to test
This is only relevant when rendering errors while doing an async task. So you can
raisean error in one of theassign_asyncfunction calls to see.If you raise errors elsewhere in the code, the page will behave in accordance to the description on LiveView's page on error and exception handling, in that it'll usually just reload as if nothing happened.