SF2.0[LAUNCH]: Adjust Ferry line pages to support linking to SF2.0 (JS style)#3067
Open
SF2.0[LAUNCH]: Adjust Ferry line pages to support linking to SF2.0 (JS style)#3067
Conversation
…op, and to send the user ot the new SF2.0 instead of opening a modal. Updated tests and types to suit.
lvachon1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Adjust Ferry line pages to support linking to SF2.0
Implementation
Updated schedule finder form to use a normal select for the origin stop, and to send the user ot the new SF2.0 instead of opening a modal. Updated tests and types to suit.
Screenshots
Screen.Recording.2026-03-31.at.10.12.15.AM.mov
How to test
Visit a ferry page and click the schedules & maps tab.
Choose an origin and direction from the updated form.
Notice the modal no longer opens onChange.
Click [Get Schedules] and observe that the new SF2.0 opens as a whole page and not as a modal
⛴️ http://localhost:4001/schedules/Boat-F4/line
Note this will affect every SF1.0 input form, but so far in my testing (on bus, CR, and subway) it still works as expected: It sends the user the right /departures/ page or updates the SF1.0 modal if they're still in that.
🚂 http://localhost:4001/schedules/CR-NewBedford/line
🚇 http://localhost:4001/schedules/Red/line?schedule_finder%5Bdirection_id%5D=0&schedule_finder%5Borigin%5D=place-portr
🚌 http://localhost:4001/schedules/1/line