feat(SF2.0): Add The Squiggle for collapsed trip details#3059
Draft
joshlarson wants to merge 1 commit intomainfrom
Draft
feat(SF2.0): Add The Squiggle for collapsed trip details#3059joshlarson wants to merge 1 commit intomainfrom
joshlarson wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎〰️ Draw the squiggle
Implementation
lined_list_itemdepending on whether the "more trips" section (this also resolves a kind of annoying visual bug where "Show fewer stops" wasn't aligned exactly the same as "Show more stops", so the text looked like it jumped around a little bit.Screenshots
How to test
Go to any departures page and see how The Squiggle is there (when there are "more stops" to show), and disappears when "more stops" is expanded.
Notes
Looking at the page zoomed in and expanding "more stops" shows off the fact that the borders for expanded stops appear to be on top of the line diagram, as in the screenshot below. That's an existing issue, unrelated to the work in this PR, and is captured in a different ticket.
(This screenshot was taken in prod)
Blocked by:
mbta-route-*, same as fill color mbta_metro#35