Skip to content

fix(Parse): parse last_trip#991

Merged
runkelcorey merged 3 commits intomasterfrom
fix-last-trip
Mar 31, 2026
Merged

fix(Parse): parse last_trip#991
runkelcorey merged 3 commits intomasterfrom
fix-last-trip

Conversation

@runkelcorey
Copy link
Copy Markdown
Contributor

@runkelcorey runkelcorey commented Mar 31, 2026

Summary of changes

https://mbta.slack.com/archives/C03K6NLKKD1/p1774959539260629?thread_ts=1774453828.583339&cid=C03K6NLKKD1

  1. Added test to check if the JSON passed matched the Model.Prediction parsed
  2. Added last_trip to Parse.TripUpdates

I also see that Parse.TripUpdatesTest doesn't check much. I'm going to add another PR to increase the coverage.

@runkelcorey runkelcorey added bug Something isn't working elixir Pull requests that update Elixir code labels Mar 31, 2026
@runkelcorey runkelcorey self-assigned this Mar 31, 2026
@runkelcorey runkelcorey requested a review from a team as a code owner March 31, 2026 16:08
@runkelcorey runkelcorey requested review from npatel-mbta and removed request for a team March 31, 2026 16:08
npatel-mbta
npatel-mbta reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@npatel-mbta npatel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@runkelcorey runkelcorey merged commit 5f48bd1 into master Mar 31, 2026
36 checks passed
@runkelcorey runkelcorey deleted the fix-last-trip branch March 31, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npatel-mbta npatel-mbta npatel-mbta approved these changes

Assignees

@runkelcorey runkelcorey

Labels

bug Something isn't working elixir Pull requests that update Elixir code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@runkelcorey @npatel-mbta