feat(StateMediator): add stop events children to S3 mediator#986
Merged
runkelcorey merged 5 commits intomasterfrom Mar 26, 2026
Merged
feat(StateMediator): add stop events children to S3 mediator#986runkelcorey merged 5 commits intomasterfrom
runkelcorey merged 5 commits intomasterfrom
Conversation
lemald
reviewed
Mar 26, 2026
lemald
approved these changes
Mar 26, 2026
Member
lemald
left a comment
There was a problem hiding this comment.
One quick question on the README changes, but overall LGTM. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 📸↩︎ fetch s3 file (StateMediator)
stop_event_childrenusingS3MediatortoStateMediatorfollowing the model ofcr_crowding_childrenThis approach uses a feature flag set to
falseby default so that this PR is release-ready. Additionally, the functions to check for the env vars won't raise an error if the variables are not found. Eventually, they probably should. First, I want to merge updates to the ECS configuration and IAM policies so that the API can actually find variables and read the stop_events feed.How were these changes validated?
mix phx.serverlocally, saw success whenSTOP_EVENTS_ENABLEDisfalseand when all stop events env vars were configuredWhat should reviewers consider?
stop_events? It isn't unwieldy but it's starting to look crufty