medium style overhaul for the ecosystem to have better consistency across the pages and fix some issues#3172
medium style overhaul for the ecosystem to have better consistency across the pages and fix some issues#3172
Conversation
…ross the pages and fix some issues Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
Looks like the filters stopped working on my phone on this PR deployment. |
Seems like its caused by cloudflare and cors:
Using https://bb593a6f.matrix-website.pages.dev/ecosystem/servers/ instead works fine |
awtj8o81ryywg793
left a comment
There was a problem hiding this comment.
Just a few small suggestions.
Note that this explicitly disallows links to be rendered as nested a tags are not working in html spec. Therefor we strip them. Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Deploying matrix-website with
|
| Latest commit: |
9cd3ef3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bc5f998.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-overhaul-ecosystem.matrix-website.pages.dev |
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
There was a problem hiding this comment.
Everything so far looks good to me. Thank you for implementing my suggested changes.
There are other areas in files not currently part of this request that exhibit the same issue. Would you mind including fixes for those in this PR?
See:
- line 21 of
templates/ecosystem/bridge_implementations.html - line 12 of
templates/shortcodes/hosting_providers.html
In addition to these files, do we know why we use a <span> element for the description of each integration? Please refer to line 6 of templates/shortcodes/all_integrations.html. I would suggest switching the <span> to a <p> element, with the .description class assigned so its styling matches the other ecosystem pages.
…he bridges Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
I assume the answer to this question will be "yes," but I want to confirm. Is it intended for the hosting provider card to look similar yet different from the other ecosystem cards? I'm mainly referring to the larger font used for the hosting provider card's description compared to that of the other ecosystem cards. I also noticed a responsive styling bug on the hosting providers page. If you set your browser's viewport to |
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
As discussed in #3219 (comment) I do like the idea of |
HarHarLinks
left a comment
There was a problem hiding this comment.
No need to implement all my comments in this PR, but at least this one should not introduce regressions.
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
|
@HarHarLinks please take another look. I did some fixes but not all:
I also applied all suggestions by @awtj8o81ryywg793 I didnt fix the invisible buttons on mobile for the SDKs. No idea how to make that better right now -> defer to an issue please? Either way lets have another round of reviews @HarHarLinks and @awtj8o81ryywg793 ? |
| row-gap: .8rem; | ||
| gap: .8rem; | ||
| margin-block: 2rem 3rem; | ||
| margin-inline: auto; |
There was a problem hiding this comment.
| margin-inline: auto; | |
| margin-inline: auto; | |
| justify-content: center; |
| privilege.matrix = "Homeserver Admin" # Any of Homeserver Admin, Room Admin, None | ||
| [bridges.supports] | ||
| dm = true | ||
| direct_messages = true |
There was a problem hiding this comment.
this needs to make it into CONTENT.md
There was a problem hiding this comment.
server cards are not clickable, yet they highlight (explicitly per servers.scss).
a lot of project cards are not clickable yet highlight.
clients and bridges are the only ones that are actually clickable.
meanwhile hosting cards are not clickable and do not highlight.
if we decide to give clickable cards or cards in general this visual feature, I think this PR should include for /branding cards to also highlight.
perhaps the highlighting feature should a ~globally available css class?
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>







Description
This fixes:
Related issues
Role
Website WG Hat :)
Timeline
Soon? Never? Now? When the moon phase turned 23 times and its the second blood moon after the third wave of a silent night?
Signoff
Please sign off your individual commits or whole pull request.
See commits :)