Add an option to pass an existing figure to get_grid#55
Add an option to pass an existing figure to get_grid#55PeterMinin wants to merge 5 commits intomatplotlib:masterfrom
Conversation
|
So I think that I have to take a closer look at the code to see what that will mean for the mechanism we're using to produce the GridSpec, though, and for how convenient the module is to use. |
|
I think in the long term it might be best to re-factor all the stuff that requires a figure out into some separate mechanism, to make it easier to re-use this with other plotting systems, but since we're so tightly tied to @PeterMinin Any chance you can add a test for this? I think the best way is to mock out Edit: Some examples of similar mocking are in tests/test_grids.py, which is where the test for this new behavior should go as well. |
|
Yes, hopefully I'll be able to do it in a couple of days. |
In case you decide that passing a figure in is ok (#54), here is an implementation :)
Thank you for this project!