Skip to content

Make sure columns get new width if contents stretch more than original width. (mathjax/MathJax#3423)#1427

Open
dpvc wants to merge 1 commit intodevelopfrom
issue3423
Open

Make sure columns get new width if contents stretch more than original width. (mathjax/MathJax#3423)#1427
dpvc wants to merge 1 commit intodevelopfrom
issue3423

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Feb 5, 2026

This PR fixes an error with mtable column widths when a cell stretches to wider than the original column's width (e.g., when the contents is a single mo with minsize that makes it bigger).

The problem was that after stretching the mo, the new bounding box width wasn't being computed (OOPS!).

Resolves issue mathjax/MathJax#3423 (this time correctly).

@dpvc dpvc requested a review from zorkow February 5, 2026 01:22
@dpvc dpvc added this to the v4.1.1 milestone Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.51%. Comparing base (b189f7e) to head (7dd72aa).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
ts/output/common/Wrappers/mtable.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1427      +/-   ##
===========================================
- Coverage    86.51%   86.51%   -0.01%     
===========================================
  Files          340      340              
  Lines        86002    86003       +1     
  Branches      3186     3186              
===========================================
  Hits         74406    74406              
- Misses       11596    11597       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkra
Copy link
Contributor

pkra commented Feb 5, 2026

Thanks for the quick fix, @dpvc. Happy to test develop once the PR lands.

zorkow
zorkow previously approved these changes Feb 5, 2026
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not work for me in the SVG renderer. I can still see the problem for the minimal example:

\begin{CD} 
A @= B
\end{CD}

@zorkow zorkow dismissed their stale review February 5, 2026 15:35

Hit the approved by accident.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not work for me in the SVG renderer. I can still see the problem for the minimal example:

\begin{CD} 
A @= B
\end{CD}

@dpvc
Copy link
Member Author

dpvc commented Feb 5, 2026

@zorkow, it works for me. Are you sure you recompiled before testing? Can you check again?

@dpvc dpvc requested a review from zorkow February 5, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants