Skip to content

Fix nested embeds errors#115

Merged
mathieuprog merged 2 commits intomathieuprog:masterfrom
nduitz:fix-nested-embeds-errors
Mar 10, 2026
Merged

Fix nested embeds errors#115
mathieuprog merged 2 commits intomathieuprog:masterfrom
nduitz:fix-nested-embeds-errors

Conversation

@nduitz
Copy link
Contributor

@nduitz nduitz commented Dec 5, 2024

No description provided.

@nduitz
Copy link
Contributor Author

nduitz commented Jul 1, 2025

Hey there, you got any feedback on this?

@ryancurtin
Copy link

ryancurtin commented Mar 10, 2026

@nduitz - I can confirm that I ran into the same issue you had and that this fix worked for me. Thanks for figuring it out, and hopefully this can be merged!

EDIT- There appears to be some overlap with this code in #132. For now, I'll keep maintain my fork with these changes and follow that issue.

ryancurtin added a commit to NexadataAI/polymorphic_embed that referenced this pull request Mar 10, 2026
…within a <.polymorphic_embed_inputs_for /> (see mathieuprog#115 and mathieuprog#132 on upstream)
@mathieuprog mathieuprog merged commit 6aa26ed into mathieuprog:master Mar 10, 2026
@nduitz
Copy link
Contributor Author

nduitz commented Mar 10, 2026

Thanks <3 I will check the #132 and rebase it on main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants