[CircularProgressIndicator] Fix full circle track seam artifact#5028
Open
Nanamare wants to merge 1 commit intomaterial-components:masterfrom
Open
[CircularProgressIndicator] Fix full circle track seam artifact#5028Nanamare wants to merge 1 commit intomaterial-components:masterfrom
Nanamare wants to merge 1 commit intomaterial-components:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
When drawing a full circle (360°) track, drawArc() creates a visible seam at 0° where the start/end caps or rounded blocks overlap. Replace drawArc() with drawOval() for full circle tracks, which has no start/end point and renders a seamless circle. Partial arcs (indicators) continue to use drawArc() unchanged. Fixes material-components#5027
352eab9 to
4bf0817
Compare
drchen
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CircularDrawingDelegate.drawArc()renders a full circle (360°) track withtrackCornerRadius > 0, the start/end caps or rounded blocks overlap at 0°, producing a visible seam artifactdrawArc()withdrawOval()for full circle tracks —drawOvalhas no start/end point, so the seam is eliminated entirelydrawArc()logic unchangedFix-CircularProgressIndicator.mov
Demo branch
A separate branch with catalog app changes to reproduce and verify the fix:
demo/circular-indicator-seam-reproductionIt includes:
Theme.Material3.DayNight.NoActionBarCircularProgressIndicatorstyle withtrackCornerRadius=8dpto make the artifact visibleTest plan
CircularProgressIndicatorwithtrackCornerRadius > 0renders a seamless full circle trackdrawOvalpath)./gradlew test— JVM tests passFixes #5027