feat: Add bunnyhopping control CVars#3
Open
Void-n-Null wants to merge 1 commit intomastercomfig:tc2-modfrom
Open
feat: Add bunnyhopping control CVars#3Void-n-Null wants to merge 1 commit intomastercomfig:tc2-modfrom
Void-n-Null wants to merge 1 commit intomastercomfig:tc2-modfrom
Conversation
Introduce two new ConVars to control bunnyhopping behavior: - tf_restrict_bunnyhopping: Restricts speed gain from bunnyhopping (default: enabled) (Matches TF2 functionality by default) - tf_automatic_bunnyhopping: Allows automatic bunnyhopping when holding jump (default: disabled) (Matches TF2 functionality by default) Modified CheckJumpButton() to respect these new CVars, providing more flexibility in movement mechanics. The new CVars are labeled as cheats to match the rest of the movement based `tf_` CVars.
Member
|
I won't be taking this for now, since I think Valve has explicitly denied this behavior being a thing, and I'd like at least for the first major update of TC2 until adding this. It can help a lot with prediction for servers which try to enable this custom behavior, so I do think it's legitimate in the long term. |
731236d to
d3bfc64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce two new ConVars to control bunnyhopping behavior. They default to vanilla TF2 behavior, so no server is affected unless they explicitly opt-in. But for servers that want these controls, it enables clean, native configuration of movement mechanics without needing plugins or code changes.
Implementation
This PR introduces two new ConVars to provide more granular control over bunnyhopping mechanics:
tf_restrict_bunnyhopping: Controls whether players can gain speed through consecutive jumpstf_automatic_bunnyhopping: Enables automatic jumping while holding the jump buttonThe implementation modifies
CheckJumpButton()insrc\game\shared\tf\tf_gamemovement.cppto check these ConVars before applying bunnyhopping mechanics. Both variables are registered with the FCVAR_CHEAT flag to maintain consistency with other movement-related ConVars. There could be some further discussion on if the CVars count as cheats.Checklist
tc2-modbranch.Optional checklist:
Testing Checklist