Skip to content

feat: Add bottom tab bar for mobile navigation (Phase 1)#680

Open
marcodejongh wants to merge 1 commit intomainfrom
claude/spotify-ui-redesign-phase-1-D57aP
Open

feat: Add bottom tab bar for mobile navigation (Phase 1)#680
marcodejongh wants to merge 1 commit intomainfrom
claude/spotify-ui-redesign-phase-1-D57aP

Conversation

@marcodejongh
Copy link
Owner

Add a persistent bottom tab bar with Climbs, Search, and New tabs
that replaces mobile-specific buttons previously in the header.
Search opens a right drawer with filters, New opens a bottom drawer
with Create Climb and My Playlists options. The tab bar is hidden
on desktop (>=768px) where sidebar handles these functions.

  • New BottomTabBar component with iOS safe area support
  • New CreateDrawer component for create/playlist actions
  • Remove mobile SearchButton from header (moved to tab bar)
  • Remove Create Climb from mobile meatball menu (moved to tab bar)
  • Mark Phase 1 as done in redesign plan

https://claude.ai/code/session_01ReTs4AchTet4cCNkUDsgm1

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Preview, Comment Feb 6, 2026 0:19am

Request Review

Add a persistent bottom tab bar with Climbs, Search, and New tabs
that replaces mobile-specific buttons previously in the header.
Search opens a right drawer with filters, New opens a bottom drawer
with Create Climb and My Playlists options. The tab bar is hidden
on desktop (>=768px) where sidebar handles these functions.

- New BottomTabBar component with iOS safe area support
- New CreateDrawer component for create/playlist actions
- Remove mobile SearchButton from header (moved to tab bar)
- Remove Create Climb from mobile meatball menu (moved to tab bar)
- Mark Phase 1 as done in redesign plan

https://claude.ai/code/session_01ReTs4AchTet4cCNkUDsgm1
@marcodejongh marcodejongh force-pushed the claude/spotify-ui-redesign-phase-1-D57aP branch from 715c333 to a75a05b Compare February 6, 2026 12:19
@claude
Copy link

claude bot commented Feb 6, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. Duplicate playlists functionality - header.tsx:157-161 still includes "My Playlists" in the mobile meatball menu, but create-drawer.tsx also adds "My Playlists". This creates duplicate menu entries for mobile users.

  2. Hardcoded color value - bottom-tab-bar.module.css:7 uses background: #fff and border-top: 1px solid #E5E7EB instead of referencing design tokens or CSS variables. Per CLAUDE.md, design tokens should be used.

  3. Incomplete test checklist - docs/spotify-ui-redesign-plan.md marks Phase 1 as complete but several items are still unchecked:

    • "Home tab navigates to /list when feature flag is off"
    • "Home tab navigates to /home when NEXT_PUBLIC_ENABLE_HOME_SCREEN=true"
    • "Tab bar does not overlap QueueControlBar"
    • "Content area scrolling is not blocked by tab bar"
    • "Tab bar shows on play/view pages, hides on create page"
  4. Missing Search badge indicator - The original search-button.tsx shows a badge with result count when filters are active. The new bottom tab bar Search button has no such indicator, reducing discoverability of active filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants