Add tests for ble-client, climb-history, and grade-colors modules#675
Open
marcodejongh wants to merge 1 commit intomainfrom
Open
Add tests for ble-client, climb-history, and grade-colors modules#675marcodejongh wants to merge 1 commit intomainfrom
marcodejongh wants to merge 1 commit intomainfrom
Conversation
Enhanced the existing test suites for 3 previously undocumented modules: - ble-client (33 tests): Connection lifecycle, failure handling, reconnection timing via loop(), onDisconnect state transitions, send guards, and multiple connection cycles - climb-history (43 tests): Circular buffer LIFO ordering, duplicate UUID detection, clearCurrent behavior, bounds checking, null/truncation edge cases, and rapid add/clear stress testing - grade-colors (43 tests): Already comprehensive, no changes needed Also made Arduino.h mock millis() controllable via mockMillis global to support timer-based reconnection tests in ble-client. Updated FIRMWARE_TESTING.md to document all 3 modules (now 364 total tests across 11 modules). https://claude.ai/code/session_01SujBT5DmwKZnqzf75wccaE
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Claude Review✅ Ready to merge - No significant issues found. This PR adds well-structured tests for three firmware modules with good coverage of edge cases, error handling, and state transitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the existing test suites for 3 previously undocumented modules:
Also made Arduino.h mock millis() controllable via mockMillis global to support timer-based reconnection tests in ble-client.
Updated FIRMWARE_TESTING.md to document all 3 modules (now 364 total tests across 11 modules).
https://claude.ai/code/session_01SujBT5DmwKZnqzf75wccaE