Skip to content

Enable MoonBoard climb details/view page#671

Open
marcodejongh wants to merge 1 commit intomainfrom
claude/enable-moonboard-climb-details-BslNC
Open

Enable MoonBoard climb details/view page#671
marcodejongh wants to merge 1 commit intomainfrom
claude/enable-moonboard-climb-details-BslNC

Conversation

@marcodejongh
Copy link
Owner

  • Remove viewDetails exclusion from climb-card for MoonBoard climbs
  • Fix getClimb to skip sizeEdges validation for MoonBoard (uses fixed grid)
  • Add MoonBoard-specific redirect logic using static config instead of
    Aurora generated product-sizes data
  • Exclude openInApp action for MoonBoard (no Aurora app URL)
  • Make auroraAppUrl optional in ClimbViewActions

Closes #617

https://claude.ai/code/session_014W5j5Jk4pMWrzuWCTQK6aB

- Remove viewDetails exclusion from climb-card for MoonBoard climbs
- Fix getClimb to skip sizeEdges validation for MoonBoard (uses fixed grid)
- Add MoonBoard-specific redirect logic using static config instead of
  Aurora generated product-sizes data
- Exclude openInApp action for MoonBoard (no Aurora app URL)
- Make auroraAppUrl optional in ClimbViewActions

Closes #617

https://claude.ai/code/session_014W5j5Jk4pMWrzuWCTQK6aB
@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Feb 6, 2026 10:08am

Request Review

@claude
Copy link

claude bot commented Feb 6, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. Missing fallback/error handling for invalid layout - packages/web/app/[board_name]/[layout_id]/[size_id]/[set_ids]/[angle]/view/[climb_uuid]/page.tsx:116-142: When getLayoutById() returns undefined or selectedSets.length === 0 for MoonBoard, the redirect silently fails and the page continues without redirecting. Consider throwing an error or handling this case explicitly.

  2. Potential undefined return from getClimb - packages/web/app/lib/data/queries.ts:49: The function returns result[0] as Climb which could be undefined if no climb is found. This pre-existing issue becomes more relevant with MoonBoard since validation is skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MoonBoard climb view/details page

2 participants