Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

🧪 Add unit tests for sanctions CLI commands#38

Closed
mapleleaflatte03 wants to merge 3 commits intomainfrom
tests/sanctions-cli-13149159199046579460
Closed

🧪 Add unit tests for sanctions CLI commands#38
mapleleaflatte03 wants to merge 3 commits intomainfrom
tests/sanctions-cli-13149159199046579460

Conversation

@mapleleaflatte03
Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The cmd_apply function in economy/sanctions.py (and the related cmd_lift function) lacked unit tests.

📊 Coverage: What scenarios are now tested

  • Happy path for cmd_apply: validates that when apply_sanction returns True, load_ledger, apply_sanction, and save_ledger are called correctly.
  • Error path for cmd_apply: validates that when apply_sanction returns False, save_ledger is bypassed.
  • Happy path for cmd_lift: validates that when lift_sanction returns True, load_ledger, lift_sanction, and save_ledger are called correctly.
  • Error path for cmd_lift: validates that when lift_sanction returns False, save_ledger is bypassed.

Result: The improvement in test coverage
The CLI commands in economy/sanctions.py are now fully unit tested for their routing and save logic. Also fixed a brittle test in test_capsule_scoping.py that assumed a hardcoded founding org ID which caused test failures.


PR created automatically by Jules for task 13149159199046579460 started by @mapleleaflatte03

Added `economy/tests/test_sanctions.py` to unit test `cmd_apply` and `cmd_lift`. Used `unittest.mock` to verify that `save_ledger` is correctly called only when `apply_sanction` or `lift_sanction` returns True. Also fixed a brittle hardcoded organization ID in `test_capsule_scoping.py` that caused test failures when run after local `quickstart.py` initialization.

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules bot and others added 2 commits March 29, 2026 08:46
Added `economy/tests/test_sanctions.py` to unit test `cmd_apply` and `cmd_lift`. Used `unittest.mock` to verify that `save_ledger` is correctly called only when `apply_sanction` or `lift_sanction` returns True. Also fixed a brittle hardcoded organization ID in `test_capsule_scoping.py` that caused test failures when run after local `quickstart.py` initialization.

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Added `economy/tests/test_sanctions.py` to unit test `cmd_apply` and `cmd_lift`. Used `unittest.mock` to verify that `save_ledger` is correctly called only when `apply_sanction` or `lift_sanction` returns True. Also fixed a brittle hardcoded organization ID in `test_capsule_scoping.py` that caused test failures when run after local `quickstart.py` initialization.

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
@mapleleaflatte03
Copy link
Copy Markdown
Owner Author

This repository is now archived for historical reference.\n\nActive Meridian development has moved to the monorepo:\nhttps://github.com/mapleleaflatte03/meridian\n\nPlease open a new PR against the monorepo if this change is still needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant