Skip to content

Migrate from javax to jakarta#32

Open
fedeliallalinea wants to merge 1 commit intomapfish:mainfrom
fedeliallalinea:jakarta-migration
Open

Migrate from javax to jakarta#32
fedeliallalinea wants to merge 1 commit intomapfish:mainfrom
fedeliallalinea:jakarta-migration

Conversation

@fedeliallalinea
Copy link
Copy Markdown

I migrated mapfish-print-v2 from javax to jakarta in order to use it with >=tomcat-10. For my purposes PR seems to work, I use mapfish-print as war, but I am not sure if I have migrated everything correctly.

@jodygarnett
Copy link
Copy Markdown
Collaborator

Thanks, we are looking at doing that for GeoServer 3 activity also.

@aaime
Copy link
Copy Markdown
Collaborator

aaime commented Feb 5, 2026

@jodygarnett this has been done already, right?

@jodygarnett
Copy link
Copy Markdown
Collaborator

jodygarnett commented Feb 9, 2026

I believe this PR is stale and the work has been accomplished as part of the GS3 activities.

@fedeliallalinea are you in position to check? We just went from spring6 to spring7.

@jodygarnett
Copy link
Copy Markdown
Collaborator

Okay this one has an update from com.codahale.metrics.servlet.InstrumentedFilterContextListener to
io.dropwizard.metrics.servlet.InstrumentedFilterContextListener.

Which I remember hitting for another project.

Here is the dependency change:

      <dependency>
        <groupId>io.dropwizard.metrics</groupId>
        <artifactId>metrics-jakarta-servlet</artifactId>
        <version>${metrics-version}</version>
      </dependency>
      <dependency>
        <groupId>io.dropwizard.metrics</groupId>
        <artifactId>metrics-jakarta-servlets</artifactId>
        <version>${metrics-version}</version>
      </dependency>

So we have an update of io.dropwizard.metrics to perform.

Signed-off-by: Marco Genasci <fedeliallalinea@gmail.com>
@fedeliallalinea
Copy link
Copy Markdown
Author

I updated the branch to make the program work as a webapp (.war) as well.

@sebr72 sebr72 self-requested a review February 27, 2026 20:32
Copy link
Copy Markdown

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR indeed address the metrics jakarta dependency. But it also adds the logging. @jodygarnett Although I approve it, please confirm you don't know of any reason to separate or make this part more configurable ? I let you comment or merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants