sdk/go,controller: add TopologyInfo deserialization and flex-algo controller support#3515
Draft
ben-malbeclabs wants to merge 12 commits intomainfrom
Draft
sdk/go,controller: add TopologyInfo deserialization and flex-algo controller
support#3515ben-malbeclabs wants to merge 12 commits intomainfrom
ben-malbeclabs wants to merge 12 commits intomainfrom
Conversation
This was referenced Apr 10, 2026
Draft
…pport - Add flex_algo_node_segments field to Interface::V2; add deserialize_legacy_v2_interface for reading pre-RFC-18 accounts - Add MigrateDeviceInterfaces processor: rewrites pre-RFC-18 device accounts (no flex_algo bytes) to new V2 layout; idempotent so the activator startup sweep can call it unconditionally; accepts foundation, device owner, or activator authority as signer - Wire MigrateDeviceInterfaces into entrypoint and instructions - Update ActivateLink to pass unicast_default_topology_pda unconditionally; processor tags link only when account is initialized - Update topology backfill/create processors - Remove V3 discriminant from smartcontract Go SDK; DeserializeInterfaceV2 now reads flex_algo_node_segments unconditionally (requires migration) - Register topology commands in Rust SDK - Add integration tests for MigrateDeviceInterfaces: idempotency, authorization (unauthorized/activator/non-signer), legacy account migration
…mmands FlexAlgo teardown commands (no traffic-engineering, no next-hop resolution ribs, no router traffic-engineering) were emitted unconditionally whenever FlexAlgoEnabled=false. In e2e, no --features-config is passed so Config is nil. Issuing these no-ops on fresh cEOS caused configure session errors which rolled back the entire session, including the no neighbor command used to remove disconnected users. Fix: guard all FlexAlgo cleanup branches with else-if $.Config so they only fire when a features config was loaded (FlexAlgo was deployed or is being disabled). When Config is nil, the controller was never configured for FlexAlgo, so there is nothing to clean up. Update all render fixtures and the flex-algo-disabled test case (now uses a non-nil Config with FlexAlgo.Enabled=false) to match.
ben-malbeclabs
force-pushed
the
bc/rfc18-pr5
branch
from
3272eb1 to
72ca31d
Compare
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC-18 flex-algo · PR 5 of 5 · see `rfcs/rfc-0018-flex-algo.md`
Depends on: #3497 (PR 1) — does not require PRs 2–4; can merge after PR 1
Series: #3497 · #3512 · #3513 · #3514 · #3515
Summary of Changes
Diff Breakdown
Fixtures are two new EOS golden configs; most of the test weight is in render tests and the compat boundary update.
Key files (click to expand)
Testing Verification