feat: add .oakappignore to all examples#708
Closed
matyama wants to merge 1 commit intoluxonis:mainfrom
Closed
Conversation
Collaborator
|
I think this can be open as a "real" PR. Then we remove any conflicts and we can test it out with the standalone HIL tests |
This patch adds or modifies `.oakappignore` everywhere based on the newly introduced `.oakappignore` template. Note that most examples use the template ignore file and only the `custom-frontend` apps have their ignore files updated (merged with the template).
matyama
force-pushed
the
feat/add-oakappignore
branch
from
3db06cc to
5d227e0
Compare
Merged
klemen1999
added a commit
that referenced
this pull request
Jul 17, 2025
* feat: add .oakappignore to all examples This patch adds or modifies `.oakappignore` everywhere based on the newly introduced `.oakappignore` template. Note that most examples use the template ignore file and only the `custom-frontend` apps have their ignore files updated (merged with the template). * fix for running workflow on external origin --------- Co-authored-by: Martin Matyášek <martin.matyasek@gmail.com>
Collaborator
|
Merged through #715 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This patch adds or modifies
.oakappignoreeverywhere based on the newly introduced.oakappignoretemplate.Note: I'll keep this as a draft till luxonis/oak-template#2 is merged.
Specification
Note that most examples use the template ignore file and only the
custom-frontendapps have their ignore files updated (merged with the template).Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
I've tried building the default app as well as one of the custom-frontend apps locally (with a local venv and mypy cache) and inspected the resulting package - whether it properly excludes ignored files.