This repository was archived by the owner on Apr 27, 2023. It is now read-only.
Conversation
Contributor
|
Ok, looking at this, the code looks reasonable. I'm not sure if "spin" is the right way to describe it -- the main difference is that you're doing a non-blocking operation (and yes, spinning), instead of blocking. I guess its ok though. That said, of course spinning is a tragically bad idea to use in production. :-) |
Contributor
Author
|
I call this a spin loop since it is spinning on recv. It could also be called a busy-wait or busy-looping according to wikipedia (https://en.wikipedia.org/wiki/Busy_waiting). If you want me to change the name then I'm fine with that, but I think spin best describes what it does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want this feature for two reasons:
This option can reduce latency by 10-14% on SmartOS so I think it's a good feature to have to demonstrate the amount of overhead the blocking call can add.