Missing async/await in addItem since add fetch#30
Open
akaigyouhou wants to merge 1 commit intolucasfcosta:masterfrom
Open
Missing async/await in addItem since add fetch#30akaigyouhou wants to merge 1 commit intolucasfcosta:masterfrom
akaigyouhou wants to merge 1 commit intolucasfcosta:masterfrom
Conversation
…ome async/await logical in three test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are missing async/await in addItem since add fetch to this function. Thus missing async/await in handleAddItem function. and missing async/await logical in three test file. After changing tests in main.test.js to async function, there are also need to add await logic in the test, otherwise the test will fail.