feat: Modularize Lunatik package and enable granular selection#9
Open
Zapper9982 wants to merge 12 commits intoluainkernel:openwrt-23.05from
Open
feat: Modularize Lunatik package and enable granular selection#9Zapper9982 wants to merge 12 commits intoluainkernel:openwrt-23.05from
Zapper9982 wants to merge 12 commits intoluainkernel:openwrt-23.05from
Conversation
Author
|
Proof of work : 
|
|
hey, @Zapper9982 did you try to build? it seems that autogen is not being called any longer..
|
Author
Hi yes lemme look into this |
Author
|
@lneto So i got down to it , there seems to be an issue in
making it : should fix it The original Lua code has a conditional 64-bit shift that is correctly excluded by the preprocessor on 32-bit targets, but GCC still analyzes and warns about it. The fix makes the shift operation type-safe by explicitly casting to a 64-bit type before shifting, eliminating the warning without changing runtime behavior |
lneto
reviewed
Jan 19, 2026
kernel/lunatik/Makefile
Outdated
Comment on lines
89
to
119
| DEPENDS:=\ | ||
| +lua5.4 | ||
| DEPENDS:=+lua5.4 |
There was a problem hiding this comment.
please, don't mix style changes and feat
lneto
reviewed
Jan 19, 2026
kernel/lunatik/Makefile
Outdated
| define Build/Prepare | ||
| $(Build/Prepare/Default) | ||
| cd $(PKG_BUILD_DIR) && ./gensymbols.sh $(LUA_API) > lunatik_sym.h | ||
| cd $(PKG_BUILD_DIR) && CC=gcc ./gensymbols.sh $(LUA_API) > lunatik_sym.h |
Author
There was a problem hiding this comment.
I think we shouldnt use cross compiler here , we should use host compiler so i will make it $(HOSTCC)
I don't think it should be a problem; did you try to build the same without your patch? Lua should be correctly configured. It's most likely that your patch is breaking some config. BTW, I don't see the error you are reporting anywhere. Can you share the log? |
Author
@lneto here |
Can you make sure it's happening without your changes as well? It seems to me that you are not including the right headers. |
Author
|
Hey @lneto i have been getting an unsafe memcpy error as of now , i am not sure what to do about it |
Please, always share the full logs, so we can try to help ;-) |
Author
|
CC [M] /home/zapper9982/Documents/lunatik/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_generic/lunatik-3.6.4/lua/lparser.o |
It looks like the build is not finding this API, can you share your OpenWRT config? |
|
the build problem I have now is to sort out the dependency of luarcu on lunatik_run |
Author
yes managed to get my config right |
Author
Let me take a look into it |
Author
|
@lneto i wasnt able to reproduce the same issue you have been facing =) could u help me with what exactly you performed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR majorly refactors the Lunatik OpenWrt package to support modular selection of features .
Dynamically constructs
EXTRA_KCONFIGbased on the selected OpenWrt packages. This maps OpenWrt selection (CONFIG_PACKAGE_kmod-lunatik-) to the internal Lunatik Kconfig symbols (CONFIG_LUNATIK_).Temporarily pointed PKG_SOURCE_URL to a development fork (Zapper9982/lunatik) to verify the Kconfig integration