feat(undo): add clearRedo and clearUndo methods#920
Closed
andreim27 wants to merge 1 commit intoloro-dev:mainfrom
Closed
feat(undo): add clearRedo and clearUndo methods#920andreim27 wants to merge 1 commit intoloro-dev:mainfrom
andreim27 wants to merge 1 commit intoloro-dev:mainfrom
Conversation
Add methods to selectively clear only the redo or undo stack, preserving the other stack. This is useful when coordinating undo/redo across multiple participants (e.g., multiple editors) where a new edit in one participant should invalidate redo in all other participants without affecting their undo history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods to selectively clear only the redo or undo stack, preserving the other stack.
Motivation
When embedding a Loro document as a slice of a larger application state, the application often needs to manage undo/redo at a higher level than the individual document. For example, an editor with multiple collaborative regions might maintain a global undo coordinator that tracks which participant made the most recent edit. When a user makes an edit in one region, the redo stacks of other regions should be invalidated—since redoing an operation that predates the new edit would create confusing semantics. The existing clear() method wipes both stacks, which is too coarse for this use case. Selective clearing allows the embedding application to surgically invalidate redo without losing undo history, enabling coherent cross-document undo/redo behavior.
Changes