refactor: merge crates/loro and crates/loro-internal into one crate#919
Open
zxch3n wants to merge 9 commits intoloro-dev:mainfrom
Open
refactor: merge crates/loro and crates/loro-internal into one crate#919zxch3n wants to merge 9 commits intoloro-dev:mainfrom
zxch3n wants to merge 9 commits intoloro-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This merges
crates/loroandcrates/loro-internalinto a single core crate.crates/loro/src/internal/**and makelorothe only core implementation crateLoroDocauto-commit semantics while making the mergedLoroDoccanonicalLoro*/loro::event::*APIs as compatibility facades, and makeloro::internal::*the canonical first-party low-level surface for container/value/event/diff/undo pathscrates/loro-wasmoffloro-internalontoloro::internalwithout regressing the pending-event flush invariantcrates/loro-internal, move compat tests/assets/version files into the merged layout, and update docs/tooling to the new structureNotes
plans/20260306-merge-loro-crates.md.loro-internaltext references are historical only (plan text, changelog text, and compatibility lockfiles for older pinned git revisions).Validation
cargo test -p lorocargo check --workspacecargo test -p loro-wasmpnpm -C crates/loro-wasm build-releasecargo bench -p loro --bench merge_baseline -- --sample-size 10 --warm-up-time 0.1 --measurement-time 0.2Benchmark Highlights
1.4115 us .. 1.4424 us7.8933 us .. 8.1270 us9.0572 us .. 9.5479 us