Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rope::update_in_place()and move the old ignored rope update tests into the active suiteValidation
cargo testcargo test --releasecargo test -- --ignoredPerformance
Benchmark setup:
origin/mainat0ae02fain a clean worktreecodex/rope-correctness-perfat2a7b89acargo bench --bench bench_ord -- --quickcargo bench --bench bench_rope -- --quickQuick benchmark snapshots on this machine were mixed and noisy, so this PR does not claim a statistically significant performance improvement:
origin/mainOrdTree 100K insert[108.88, 109.23, 110.64] ms[116.49, 126.16, 164.86] ms10K random insert/delete / Rope[490.58, 511.93, 517.27] us[865.05, 889.52, 895.63] usAutomerge paper / Rope[14.096, 19.332, 20.641] ms[11.516, 11.592, 11.897] msGiven the variance, the current takeaway is correctness hardening first; performance is still mixed and should be re-measured with a more stable benchmark setup before drawing conclusions.