test(#144): increase ExclusionDetector coverage from 59% to 100%#147
Merged
test(#144): increase ExclusionDetector coverage from 59% to 100%#147
Conversation
Covers all previously uncovered paths: name property, no-exclusion-rules skip, keyword match/no-match, crop() fallback on AttributeError and ValueError, no-text early return, case-insensitive matching, and partial keyword match in match_details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/parser-core/tests/detectors/test_exclusion_detector.pywith 11 tests covering all previously uncovered paths inexclusion_detector.pytests/detectors/__init__.pyfor the new test subdirectoryChanges
packages/parser-core/tests/detectors/__init__.pypackages/parser-core/tests/detectors/test_exclusion_detector.py(11 tests)Type
Testing
exclusion_detector.pynow at 100%, overall at 94.24%python -m pytest tests/ --cov=bankstatements_corepasses locallymake docker-integrationpassed locally (not required — no changes toDockerfile,entrypoint.sh,docker-compose.yml, or production source)Checklist
Downstream impact
bankstatements_core— N/A, tests onlyCloses #144