Enhance resize function to track detent index changes#690
Open
allthetime wants to merge 1 commit into
Open
Conversation
fix(android): prevent TrueSheet collapse to detent 0 on dynamic content layout changes
|
@allthetime is attempting to deploy a commit to the RealEdge Inc Team on Vercel. A member of the Team first needs to authorize it. |
|
I'm wondering if this is the issue I’m having! I have a ride flow and sometimes when lets say a user switches to whatsapp or the map and come back the true sheet is gone, and they get upset. I hope this is the fix! |
Author
|
@karimcambridge you can give this patch a try and see! I'm running @lodev09/react-native-true-sheet@3.10.1 |
Owner
|
@allthetime do you have a video showing this bug? I'll try to replicate and see how this PR fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(android): prevent TrueSheet collapse to detent 0 on dynamic content layout changes
Summary
Type of Change
Test Plan
repro
Checklist