Add proxy tests for the AppSync service #120
Open
+406
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive proxy tests for AWS AppSync covering: - GraphQL API CRUD operations - API key management - Schema creation and introspection - Data source operations - Read-only proxy mode - Operations-based filtering Uses fixture-based cleanup to ensure no AWS resources are left behind. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add retry around put_record call as Kinesis streams may need a brief moment after reporting ACTIVE status before they can accept writes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nik-localstack
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Tests look good 🙌
One interesting observation about appsync operations
There are (at least) two operations that would incorrectly identified as WRITE requests by our logic :
Not sure if we want modify the aws_proxy.server.aws_request_forwarder.AwsProxyHandler._is_read_request in this PR to have better read-only support of the service.
I think It would be great if the agent would be able to "catch" these and improve the read-only support in general, maybe we could re-iterate on the AGENTS.md instructions to make it happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive proxy tests for AWS AppSync.
Note 🤖 : Tests have been generated via an AI agent (Claude Code).
Changes:
Uses fixture-based cleanup to ensure no AWS resources are left behind.