Added WaveOps tests for QuadReadAcrossY#993
Draft
kcloudy0717 wants to merge 3 commits intollvm:mainfrom
Draft
Conversation
Contributor
Author
12 tasks
bob80905
approved these changes
Mar 19, 2026
Contributor
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
LGTM, I won't block on the nit, but it would be nice to update the comments on both readacross x / y
bob80905
requested changes
Mar 19, 2026
Contributor
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
Just realized there are test failures caused by read across Y. Please file the appropriate issues and add the XFAILS.
Contributor
Author
Will do. Usually I delay filling any XFAILs until reported by workflows, which requires someone from the team to approve the workflow runs. I'll go over them and file appropriate issues. Thanks for the heads up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for
QuadReadAcrossYtests, resolves #883.