Skip to content

Comments

Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595

Open
jaylim95 wants to merge 1 commit intolivekit:mainfrom
jaylim95:resolve-nat-domains
Open

Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595
jaylim95 wants to merge 1 commit intolivekit:mainfrom
jaylim95:resolve-nat-domains

Conversation

@jaylim95
Copy link

Previously, these fields only accepted literal IP addresses via netip.ParseAddr. Added support for DNS resolution when SIP LB does not have a static IP but has a stable domain name.

Added resolveAddrOrHost helper that first tries parsing as a literal IP, then falls back to DNS resolution via net.LookupHost, returning the first IPv4 result.

Previously, these fields only accepted literal IP addresses via
netip.ParseAddr. Add resolveAddrOrHost helper that first tries
parsing as a literal IP, then falls back to DNS resolution via
net.LookupHost, returning the first IPv4 result.

https://claude.ai/code/session_011bUzCCC8jboSXZdeRWM2w4
@jaylim95 jaylim95 requested a review from a team as a code owner February 20, 2026 19:26
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.72%. Comparing base (0460b40) to head (5b70e0e).
⚠️ Report is 228 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sip/config.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   65.25%   62.72%   -2.53%     
==========================================
  Files          51       35      -16     
  Lines        6588     6909     +321     
==========================================
+ Hits         4299     4334      +35     
- Misses       1915     2152     +237     
- Partials      374      423      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM after CLA is signed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants