Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595
Open
jaylim95 wants to merge 1 commit intolivekit:mainfrom
Open
Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595jaylim95 wants to merge 1 commit intolivekit:mainfrom
jaylim95 wants to merge 1 commit intolivekit:mainfrom
Conversation
Previously, these fields only accepted literal IP addresses via netip.ParseAddr. Add resolveAddrOrHost helper that first tries parsing as a literal IP, then falls back to DNS resolution via net.LookupHost, returning the first IPv4 result. https://claude.ai/code/session_011bUzCCC8jboSXZdeRWM2w4
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
- Coverage 65.25% 62.72% -2.53%
==========================================
Files 51 35 -16
Lines 6588 6909 +321
==========================================
+ Hits 4299 4334 +35
- Misses 1915 2152 +237
- Partials 374 423 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dennwc
approved these changes
Feb 21, 2026
Contributor
dennwc
left a comment
There was a problem hiding this comment.
Thank you! LGTM after CLA is signed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these fields only accepted literal IP addresses via netip.ParseAddr. Added support for DNS resolution when SIP LB does not have a static IP but has a stable domain name.
Added resolveAddrOrHost helper that first tries parsing as a literal IP, then falls back to DNS resolution via net.LookupHost, returning the first IPv4 result.