Draft
Conversation
boks1971
reviewed
May 12, 2025
|
|
||
| import ( | ||
| "runtime" | ||
| "sync/atomic" |
Contributor
There was a problem hiding this comment.
We standardise on uber atomic. It is nicer to use.
paulwe
reviewed
May 13, 2025
Comment on lines
+28
to
+34
| capacity-- | ||
| capacity |= capacity >> 1 | ||
| capacity |= capacity >> 2 | ||
| capacity |= capacity >> 4 | ||
| capacity |= capacity >> 8 | ||
| capacity |= capacity >> 16 | ||
| capacity++ |
paulwe
reviewed
May 13, 2025
Comment on lines
+13
to
+14
| head *atomic.Uint32 | ||
| tail *atomic.Uint32 |
Contributor
There was a problem hiding this comment.
these are zero initialized automatically so you can avoid the extra indirection and skip initializing with New(0) if these are atomic.Uint32 instead of *atomic.Uint32
paulwe
reviewed
May 13, 2025
Comment on lines
+265
to
+268
| for i := uint32(0); i < currentBatchSize; i++ { | ||
| slotIndex := (head + i) & cb.mask | ||
| result = append(result, cb.buffer[slotIndex]) | ||
| } |
Contributor
There was a problem hiding this comment.
this can be implemented in at most 2 copies? after head has been updated is the read range safe from concurrent writes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticing some crackling noise, debugging that. The audio otherwise seems to be in the correct order.