added Single Peer Connection support to Rust by xianshijing-lk · Pull Request #888 · livekit/rust-sdks

xianshijing-lk · 2026-02-11T05:21:42Z

after setting the LIVEKIT_URL, LIVEKIT_API_KEY, LIVEKIT_API_SECRET to staging endpoint, you will see things like

run tests:
cargo test -p livekit --features "__lk-e2e-test,native-tls" -- --nocapture

cargo test -p livekit --features "__lk-e2e-test,native-tls" --test peer_connection_signaling_test -- --nocapture

[INFO audio_test] Testing with 48000Hz, 1ch. -> 48000Hz, 1ch.
[INFO livekit_api::signal_client::signal_stream] connecting to wss://xianstaging-hixkk74p.staging.livekit.cloud/rtc/v1?sdk=rust&protocol=16&auto_subscribe=1&adaptive_stream=0&version=0.7.30&join_request=EhsKFQgIEgYwLjcuMzAYECIFbWFjb3NgARICCAE%3D
[INFO livekit_api::signal_client::signal_stream] connecting to wss://xianstaging-hixkk74p.staging.livekit.cloud/rtc/v1?sdk=rust&protocol=16&auto_subscribe=1&adaptive_stream=0&version=0.7.30&join_request=EhsKFQgIEgYwLjcuMzAYECIFbWFjb3NgARICCAE%3D
[INFO livekit_api::signal_client] [CONNECT] SUCCESS: v1 path connection successful, single_pc_mode=true
[ERROR livekit_api::signal_client] [CONNECT] ====== CONNECTION ESTABLISHED ======

ladvoc · 2026-02-11T05:46:15Z

livekit/src/room/mod.rs

@@ -1059,6 +1066,35 @@ impl RoomSession {
            track_id = stream_id.into();


nitpick: This could be moved into the else block below.

ladvoc · 2026-02-11T05:51:20Z

livekit/src/room/mod.rs

+                return;
+            }
+            // In dual PC mode: answer is local, offer is remote
+            (remote_desc.unwrap(), Some(local_desc.unwrap()))


question: Is it possible for sync state to be requested at a time when the subscriber PC lacks a local or remote description? If yes or it is unclear, we should avoid unwrapping here, and instead log a warning.

Good point, I actually don't know if it is possible, but I think it is dangerous to do unwrap() here, let me address it.

livekit/src/room/mod.rs

ladvoc · 2026-02-11T05:55:51Z

livekit-api/src/signal_client/mod.rs

+    };
+
+    // Create ClientInfo
+    let client_info = proto::ClientInfo {


nitpick: Spreading ..Default::default() would be cleaner here:

let client_info = proto::ClientInfo { sdk: proto::client_info::Sdk::Rust as i32, version: options.sdk_options.sdk_version.clone().unwrap_or_default(), protocol: PROTOCOL_VERSION as i32, os: std::env::consts::OS.to_string(), client_protocol: 1, // Indicates support for RPC compression ..Default::default() };

Same for the other protobuf types below where we set an empty string or Option::None.

ladvoc

It looking good so far! Before merging, I think it's important to test various reconnect scenarios, as this change could potentially break them.

livekit-api/src/signal_client/mod.rs

…n) signaling, add tests

…back to V0

xianshijing-lk

I addressed all the comments, please take another look

livekit-api/src/signal_client/mod.rs

xianshijing-lk · 2026-02-11T21:43:56Z

livekit-api/src/signal_client/mod.rs

+    };
+
+    // Create ClientInfo
+    let client_info = proto::ClientInfo {


xianshijing-lk · 2026-02-11T21:45:09Z

livekit/src/room/mod.rs

@@ -1059,6 +1066,35 @@ impl RoomSession {
            track_id = stream_id.into();


xianshijing-lk · 2026-02-11T21:48:08Z

livekit/src/room/mod.rs

+                return;
+            }
+            // In dual PC mode: answer is local, offer is remote
+            (remote_desc.unwrap(), Some(local_desc.unwrap()))


Good point, I actually don't know if it is possible, but I think it is dangerous to do unwrap() here, let me address it.

livekit/src/rtc_engine/rtc_session.rs

xianshijing-lk · 2026-02-12T17:52:23Z

Hi team, thanks for the comments, I think I addressed them, please take another look.

Thanks.

xianshijing-lk · 2026-02-13T21:54:58Z

A gentle ping. do we have concerns on landing this PR ?

xianshijing-lk · 2026-02-14T00:50:18Z

I made some small improvements to make sure the munging code only kicks in for v1 path, and added some more tests to e2e peer connection tests

… not support v1 by default

added Single Peer Connection support to Rust

2f81100

xianshijing-lk requested review from ladvoc, lukasIO and theomonnom February 11, 2026 05:21

ladvoc reviewed Feb 11, 2026

View reviewed changes

livekit/src/room/mod.rs Outdated Show resolved Hide resolved

ladvoc reviewed Feb 11, 2026

View reviewed changes

lukasIO reviewed Feb 11, 2026

View reviewed changes

livekit-api/src/signal_client/mod.rs Outdated Show resolved Hide resolved

xianshijing-lk added 2 commits February 11, 2026 13:35

fix the code to make it work for both v0 and v1 (single peerconnectio…

430fe51

…n) signaling, add tests

fix the README and make the tests run with localhost, as it will fall…

a13c540

…back to V0

xianshijing-lk force-pushed the sxian/CLT-2547/add_single_pc_to_rust branch from 69d4597 to a13c540 Compare February 11, 2026 21:50

cargo fmt

f41ef29

xianshijing-lk commented Feb 11, 2026

View reviewed changes

xianshijing-lk mentioned this pull request Feb 12, 2026

adding single peer connection support livekit/client-sdk-cpp#57

Open

boks1971 reviewed Feb 12, 2026

View reviewed changes

livekit/src/rtc_engine/rtc_session.rs Outdated Show resolved Hide resolved

lukasIO mentioned this pull request Feb 12, 2026

Update FFI and remove napi livekit/node-sdks#599

Open

addressed the comments

3b29452

xianshijing-lk force-pushed the sxian/CLT-2547/add_single_pc_to_rust branch from 20a520d to 3b29452 Compare February 12, 2026 17:38

some improvements on corner cases and added more tests

cf74f4b

xianshijing-lk force-pushed the sxian/CLT-2547/add_single_pc_to_rust branch from d3001b0 to cf74f4b Compare February 14, 2026 00:49

fix the tests on CIs, as the CIs are running local server, which does…

630f41b

… not support v1 by default

xianshijing-lk force-pushed the sxian/CLT-2547/add_single_pc_to_rust branch from 7454be0 to 630f41b Compare February 14, 2026 01:57

fix the tests

9cf6d3b

xianshijing-lk force-pushed the sxian/CLT-2547/add_single_pc_to_rust branch from b25162e to 9cf6d3b Compare February 14, 2026 02:16

generated protobuf

614877b

		@@ -1059,6 +1066,35 @@ impl RoomSession {
		track_id = stream_id.into();

Conversation

xianshijing-lk commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ladvoc Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ladvoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xianshijing-lk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xianshijing-lk commented Feb 12, 2026

Uh oh!

xianshijing-lk commented Feb 13, 2026

Uh oh!

xianshijing-lk commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xianshijing-lk commented Feb 11, 2026 •

edited

Loading

ladvoc Feb 11, 2026 •

edited

Loading