add Simulation scenarios#1417
add Simulation scenarios#1417theomonnom wants to merge 8 commits intotheo/agent-simulations-servicefrom
Conversation
|
theomonnom
changed the base branch from
main
to
theo/agent-simulations-service
…nto theo/scenario
…nto theo/scenario
| string source_room_id = 6; | ||
| int64 created_at = 7; | ||
| Status status = 8; | ||
| string error = 9; |
There was a problem hiding this comment.
it might be good to have a collection_id here. in DB modeling, we'd want the Scenario table to reference collection_id, versus updating the collection row each time we add a scenario
| repeated Job jobs = 7; | ||
| } | ||
|
|
||
| message Scenario { |
There was a problem hiding this comment.
should we include attributes that the participant should have in here? thinking how they would simulate a sip call or otherwise, where we'd typically use participant attributes and metadata to carry through user-identity information
| message CreateScenarioFromSessionRequest { | ||
| string project_id = 1; | ||
| string room_id = 2; | ||
| string scenario_collection_id = 3; |
There was a problem hiding this comment.
I assume scenario_collection_id is putting it directly into a collection.. maybe that should be a UpdateScenario API to move it into a collection?
| string project_id = 1; | ||
| string room_id = 2; | ||
| string scenario_collection_id = 3; | ||
| string label = 4; |
There was a problem hiding this comment.
what are label and region used for?
| } | ||
|
|
||
| message AddScenarioToCollectionRequest { | ||
| string project_id = 1; |
There was a problem hiding this comment.
I think instead of the add/remove from collection APIs, updating the collection_id on a Scenario would be simpler, and less API footprint
| rpc GetSimulationRun(GetSimulationRunRequest) returns (GetSimulationRunResponse); | ||
| rpc ListSimulationRuns(ListSimulationRunsRequest) returns (ListSimulationRunsResponse); | ||
|
|
||
| rpc CreateScenario(CreateScenarioRequest) returns (CreateScenarioResponse); |
There was a problem hiding this comment.
having an UpdateScenario API would be very helpful.. especially if user is updating this from the web app
2 participants
No description provided.