Conversation
|
7718be4 to
5df213d
Compare
67e5632 to
2c50058
Compare
1816661 to
fd8587d
Compare
827e138 to
4c738b2
Compare
4c738b2 to
05e49d0
Compare
70f3963 to
9d344d5
Compare
9d344d5 to
3eec058
Compare
3eec058 to
cb5237e
Compare
dd25909 to
e0074ea
Compare
e0074ea to
b5b5c5e
Compare
7d7fb64 to
0e69006
Compare
0e69006 to
51f63fd
Compare
51f63fd to
7904266
Compare
| "@livekit/protocol": "^1.43.1", | ||
| "camelcase-keys": "^9.0.0", | ||
| "jose": "^5.1.2" | ||
| "jose": "^6.0.0" |
There was a problem hiding this comment.
🔴 Package engines field claims Node.js >=18 but jose v6 drops Node.js 18 support and breaks CJS on Node <22
Updating jose to ^6.0.0 without updating the engines field creates a compatibility mismatch. The package declares "node": ">=18" but jose v6 explicitly drops support for Node.js 18.x and earlier. More critically, jose v6 states: "CJS-style require is now only possible when require(esm) support is present in the Node.js runtime" (require(esm) was added in Node.js 22).
Impact on CJS consumers
The package exports a CJS entry point at packages/livekit-server-sdk/package.json:24 ("default": "./dist/index.cjs"). Since jose is a runtime dependency (not bundled), the CJS build will attempt to require('jose') at runtime. On Node.js versions 18–21, this will fail because jose v6 ships only ESM and those runtimes do not support require(esm). Users on Node.js 18 or 20 (both current LTS lines) who consume livekit-server-sdk via require() will get a runtime error.
The engines field at line 65 should be updated to reflect the actual minimum Node.js version required by the dependency graph (at minimum >=20, or >=22 if CJS support is needed).
Prompt for agents
Update the engines field in packages/livekit-server-sdk/package.json (currently at line 65: "node": ">=18") to reflect the minimum Node.js version required by jose v6. At minimum, change it to "node": ">=20" (jose v6 drops Node 18 support). If CJS consumers need to be supported, change it to "node": ">=22" since jose v6's CJS-style require only works with Node.js require(esm) support (added in Node 22). Alternatively, consider configuring tsup to bundle jose into the CJS output so CJS consumers on older Node.js versions are not affected.
Was this helpful? React with 👍 or 👎 to provide feedback.
This PR contains the following updates:
^5.1.2→^6.0.0Release Notes
panva/jose (jose)
v6.1.3Compare Source
Refactor
v6.1.2Compare Source
Refactor
v6.1.1Compare Source
Documentation
Refactor
v6.1.0Compare Source
Features
v6.0.13Compare Source
Refactor
v6.0.12Compare Source
Documentation
Refactor
v6.0.11Compare Source
Fixes
v6.0.10Compare Source
Refactor
v6.0.9Compare Source
Documentation
Refactor
v6.0.8Compare Source
Fixes
v6.0.7Compare Source
Documentation
Fixes
v6.0.6Compare Source
Refactor
Documentation
v6.0.5Compare Source
Refactor
Documentation
v6.0.4Compare Source
Refactor
v6.0.3Compare Source
Documentation
v6.0.2Compare Source
Documentation
v6.0.1Compare Source
Refactor
v6.0.0Compare Source
⚠ BREAKING CHANGES
Features
Refactor
Ed25519JWS Algorithm Identifier support (7a94cb9)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.