fix: do not republish tracks on reconnect#5698
Open
davidzhao wants to merge 3 commits into
Open
Conversation
republishing is handled automatically by the RTC SDK. it should be transparent to the agent. added e2e tests for both resume and reconnect. depends on: livekit/python-sdks#654
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
approved these changes
May 10, 2026
theomonnom
reviewed
May 10, 2026
Comment on lines
+359
to
+361
| await mon.assert_audio_continuous( | ||
| min_rms=_AUDIO_RMS_THRESHOLD, duration=1.5 | ||
| ) |
Member
There was a problem hiding this comment.
this makes sense, but make sure it's based on wall-clock, and not the frames being received, otherwise even if the reconnection failed, it may be continuous?
Member
Author
There was a problem hiding this comment.
yeah this is based on wall clock
Member
Author
There was a problem hiding this comment.
I forgot to check in the test file last time, it's here now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
republishing is handled automatically by the RTC SDK. it should be transparent to the agent.
added e2e tests for both resume and reconnect.
depends on: livekit/python-sdks#654