fix(elevenlabs): add validation warnings for out-of-range VoiceSettings#4775
Open
williamwarlick wants to merge 1 commit intolivekit:mainfrom
Open
fix(elevenlabs): add validation warnings for out-of-range VoiceSettings#4775williamwarlick wants to merge 1 commit intolivekit:mainfrom
williamwarlick wants to merge 1 commit intolivekit:mainfrom
Conversation
Add _validate_voice_settings() that logs warnings when VoiceSettings parameters are outside their documented ElevenLabs API ranges. Called from both TTS.__init__() and TTS.update_options(). Follows the same pattern as Cartesia's _check_generation_config(). Also fix speed range comment from [0.8 - 1.2] to [0.7 - 1.2] per ElevenLabs API docs. Closes livekit#4774
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4774
Summary
_validate_voice_settings()that logs warnings whenVoiceSettingsparams are outside their documented ElevenLabs API ranges — follows the same pattern as Cartesia's_check_generation_config()TTS.__init__()andTTS.update_options()[0.8 - 1.2]->[0.7 - 1.2]per ElevenLabs API docsMotivation
Out-of-range
VoiceSettingsvalues (e.g.speed=0.5) get sent straight to the 11labs API which silently clamps them. The voice fails and there's nothing in the logs to indicate why. The Cartesia plugin already handles this with_check_generation_config()— this brings the ElevenLabs plugin to the same level.Warnings are non-blocking (
logger.warningwithextra={}) so values still pass through.Validated Ranges
stabilitysimilarity_booststylespeed