allow flexible recording options #4758
Conversation
when starting a session, we now support record=RecordOptions() where audio, traces, logs, and transcript could be individually enabled or disabled.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a48ebef39b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
chenghao-mou
left a comment
chenghao-mou
left a comment
There was a problem hiding this comment.
One failing test, otherwise lgtm.
One thing I noticed is that we show "No observability data available" on the UI whenever traces aren't available (even when other types of data should be).
Co-authored-by: Chenghao Mou <chenghao.mou@livekit.io>
| # wait for the idle processes to be warmed up (by the main task) | ||
| await self._idle_ready.wait() | ||
| # use a timeout so start() doesn't block forever if initialization fails | ||
| try: |
There was a problem hiding this comment.
@theomonnom confirming that this should not block .start if processes take longer than init timeout
There was a problem hiding this comment.
If initialization fails, other processes will try to be spawned again. So it shouldn't block forever even without a timeout
There was a problem hiding this comment.
without this, test_slow_initialization could not start correctly... because I think each new process is hitting the timeout, so it was never able to reach capacity. wdty the right behavior should be?
There was a problem hiding this comment.
shouldn't await _wait_for_elements(start_q, num_idle_processes) already wait for those processes tho?
There was a problem hiding this comment.
But I think you're right, we shouldn't wait here, can you ignore it for this PR? I can take over
There was a problem hiding this comment.
It's used by the worker to make sure we don't register to LK Cloud until everything is ready
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Chenghao Mou <chenghao.mou@livekit.io>
3 participants
when starting a session, we now support record=RecordOptions() where audio, traces, logs, and transcript could be individually enabled or disabled.