gracefully stop AgentTask and parent agents when session close #4730
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| await self._activity.pause(blocked_tasks=blocked_tasks or []) | ||
| await activity.pause(blocked_tasks=blocked_tasks or []) | ||
|
|
||
| self._activity = self._next_activity |
There was a problem hiding this comment.
does it matter if there is a concurrent _aclose_impl call?
There was a problem hiding this comment.
this is a good question.
between the old activity close/pause to the new activity start/resume is sync codes, the closing guard is added in between to allow to close/pause the old activity since it has a lock internally and it's safe to close an activity twice.
if the session.aclose is called during next activity start/resume, the session._activity is already changed to the next activity, the aclose impl will also try to close the next activity, and since the start/resume acquired lock first, it will be started/resumed then closed immediately.
btw, I moved the closing guard to before adding agent handoff items so it won't be recorded as an handoff.
There was a problem hiding this comment.
One follow-up: we could still have double calls to drain though, right? Should we guard that as well?
There was a problem hiding this comment.
that's a good point, updated to avoid duplicated calls to the on_exit in drain.
2 participants
Uh oh!
There was an error while loading. Please reload this page.