gitea: support git credential manager oauth flow#800
Open
cmruffin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
git credential manager sets up an oauth flow which requires a redirect to a localhost port to complete the oauth flow. The proxt_redirect http:// scheme$:// directive in proxy.conf causes this to be rewritten to https://. Make an exception for redirects to localhost so that the oauth login will complete.
Benefits of this PR and context
git operations using the git credential manager with gitea can successfully set up oauth tokens.
How Has This Been Tested?
Test git clone / git fetch operations that initiate an oauth login using git for windows default installation which uses git credential manager.