Fix battery status logic for CHARGING and PENDING_CHARGE states#13742
Open
Konstantin-The-Goose wants to merge 2 commits intolinuxmint:masterfrom
Open
Fix battery status logic for CHARGING and PENDING_CHARGE states#13742Konstantin-The-Goose wants to merge 2 commits intolinuxmint:masterfrom
Konstantin-The-Goose wants to merge 2 commits intolinuxmint:masterfrom
Conversation
Fixed issue linuxmint#13686 Previously, PENDING_CHARGE was unreachable due to duplicated condition checks. This separates the logic so both states are handled correctly (i hope).
Contributor
|
Is this a typo, you've got two else if conditions the same. |
Eliezermga
approved these changes
May 2, 2026
Author
OH MY GOD yes this is a typo im so sorry |
Member
|
So, this has been tested? I'm suspicious now - the original basically did nothing, but it was submitted... now it's fixed. Sorry for having to ask these types of questions, but I didn't pick this timeline we're in. |
Author
no sorry i havent tested it. i think it fixes the issue i mentioned in the pr, but i may be wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #13686
Previously, PENDING_CHARGE was unreachable due to duplicated condition checks. This separates the logic so both states are handled correctly (i hope).